On Mon, 22 Jul 2024 15:13:08 GMT, Kevin Walls <kev...@openjdk.org> wrote:
>> Short version: >> Stop testing this test with -Xcomp by adding requires vm.compMode != "Xcomp" >> >> Make additional typo fixes and tidyups while here, it's just shocking. >> >> TestDescription.java contains the test definition, so the "requires" goes >> there, with a comment. >> >> Updates to from001.java are typos and clarifications, and a changed loop >> with a poll on a queue rather than block forever. > > Kevin Walls has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains four additional > commits since the last revision: > > - Merge remote-tracking branch 'upstream/master' into > 8332551_MemoryNotificationInfo_from001 > - formatting > - update > - 8332551: Test > vmTestbase/nsk/monitoring/MemoryNotificationInfo/from/from001/TestDescription.java > timed out Thanks for the reviews! ------------- PR Comment: https://git.openjdk.org/jdk/pull/20146#issuecomment-2243378095
