On Thu, 11 Jul 2024 21:08:20 GMT, Kevin Walls <kev...@openjdk.org> wrote:
> Short version:
> Stop testing this test with -Xcomp by adding requires vm.compMode != "Xcomp"
>
> Make additional typo fixes and tidyups while here, it's just shocking.
>
> TestDescription.java contains the test definition, so the "requires" goes
> there, with a comment.
>
> Updates to from001.java are typos and clarifications, and a changed loop with
> a poll on a queue rather than block forever.
test/hotspot/jtreg/vmTestbase/nsk/monitoring/MemoryNotificationInfo/from/from001.java
line 171:
> 169: if (!messageReceived) {
> 170: throw new TestFailure("No Notification received.");
> 171: } else {
Nit: The "else" is not really needed. Removing it will simplify the change diff.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20146#discussion_r1675021648
