On Fri, 19 Jul 2024 09:45:19 GMT, Tobias Hartmann <thartm...@openjdk.org> wrote:

>> Daniel Lundén has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Add comment and bug number
>
> test/hotspot/jtreg/serviceability/sa/ClhsdbDumpheap.java line 40:
> 
>> 38: /**
>> 39:  * @test
>> 40:  * @bug 8240989 8336753
> 
> I don't think that change makes sense because the test is not a regression 
> test for JDK-8336753.

Can/should I include the bug number in some other way (perhaps directly in the 
comment)? I'm thinking if someone reads the comment in the future and would 
like more details.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20237#discussion_r1684141326

Reply via email to