On Fri, 19 Jul 2024 09:31:01 GMT, Daniel Lundén <dlun...@openjdk.org> wrote:
>> We are seeing quite a few timeouts for >> `serviceability/sa/ClhsdbDumpheap.java` running with -Xcomp in testing, >> possibly related to >> [JDK-8324241](https://bugs.openjdk.org/browse/JDK-8324241). We should >> disable running `ClhsdbDumpheap.java` with -Xcomp, at least for now. >> >> ### Changeset >> >> - Add `@requires vm.compMode != "Xcomp"` to `ClhsdbDumpheap.java`. > > Daniel Lundén has updated the pull request incrementally with one additional > commit since the last revision: > > Add comment and bug number Looks good to me otherwise. test/hotspot/jtreg/serviceability/sa/ClhsdbDumpheap.java line 40: > 38: /** > 39: * @test > 40: * @bug 8240989 8336753 I don't think that change makes sense because the test is not a regression test for JDK-8336753. ------------- Marked as reviewed by thartmann (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/20237#pullrequestreview-2187828134 PR Review Comment: https://git.openjdk.org/jdk/pull/20237#discussion_r1684135244