On Wed, 5 Jun 2024 06:22:17 GMT, Sebastian Lövdahl <d...@openjdk.org> wrote:
>> 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid >> (Kubernetes debug container) > > Sebastian Lövdahl has updated the pull request incrementally with one > additional commit since the last revision: > > Add test for the elevated privileges case src/jdk.attach/linux/classes/sun/tools/attach/VirtualMachineImpl.java: It's going to be mostly style nits. 8-) I realise some of this was passed back and forth above (so apologies to you and to Larry for being a pain). line 281 line break before IOException 313 There is no hard limit on line length, but when you add new longest lines it's probably diverged from the file's style. Could you make some of the new comments more terse? A lot of the new code is double-spaced, which is unusual for the file for HotSpot/JDK as a whole. Is it still readable to you if we delete at least these empty lines: 274, 276, 286, 296, 303, 312, 317, 319, 324, 326 It may not quite get findTargetProcessTmpDirectory to fit on screen, but it will help. 8-) ------------- PR Comment: https://git.openjdk.org/jdk/pull/19055#issuecomment-2197407706
