On Mon, 3 Jun 2024 23:07:00 GMT, Larry Cable <d...@openjdk.org> wrote:
>> Sebastian Lövdahl has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Remove unused `SELF_PID_NS` >> - Rewrite in line with suggestion from Larry Cable > > it looks as though I can take an existing jcmd test in the container > tests and quite quickly implement an 'elevated' sidecar test... > > I'll work on that today and tomorrow, lets aim to get the 'fix' and the > test in before Thu!!! > > Rgds > > - Larry > > On 6/3/24 10:24 AM, Sebastian Lövdahl wrote: >> >> Hi Larry, no worries. :) >> >> I can try to look into writing some tests for the elevated use-cases. >> but it will be quite much treading of new ground for me, so it could >> take some time to get it done. >> >> What's your take, do we need the new tests in this PR, or could it be >> done in a follow-up? >> >> — >> Reply to this email directly, view it on GitHub >> <https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/19055*issuecomment-2145749773__;Iw!!ACWV5N9M2RV99hQ!K0MEZ8qTAcfQbuAvzL9Owp185kbnkkocR0vuh5wia4Zlg3fFzKwJo5WgGVBMUSe_N5Hef4teGHbUKcyPg2ou5TXc0g$>, >> >> or unsubscribe >> <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ANTA67SLY6ZRE5DP7RNIRR3ZFSREFAVCNFSM6AAAAABHDNNTT6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBVG42DSNZXGM__;!!ACWV5N9M2RV99hQ!K0MEZ8qTAcfQbuAvzL9Owp185kbnkkocR0vuh5wia4Zlg3fFzKwJo5WgGVBMUSe_N5Hef4teGHbUKcyPg2pvqMZDog$>. >> You are receiving this because you were mentioned.Message ID: >> ***@***.***> >> > > --------------2ZFegatR1DQpyr1B5InvHtns > Content-Type: text/html; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > <!DOCTYPE html><html><head> > <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> > </head> > <body> > it looks as though I can take an existing jcmd test in the container > tests and quite quickly implement an 'elevated' sidecar test...<br> > <br> > I'll work on that today and tomorrow, lets aim to get the 'fix' and > the test in before Thu!!!<br> > <br> > Rgds<br> > <br> > - Larry<br> > <br> > <div class="moz-cite-prefix">On 6/3/24 10:24 AM, Sebastian Lövdahl > wrote:<br> > </div> > <blockquote type="cite" ***@***.***"> > <p dir="auto">Hi Larry, no worries. :)</p> > <p dir="auto">I can try to look into writing some tests for the > elevated use-cases. but it will be quite much treading of new > ground for me, so it could take some time to get it done.</p> > <p dir="auto">What's your take, do we need the new tests in this > PR, or could it be done in a follow-up?</p> > <p>—<br> > Reply to this email directly, <a > href="https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/19055*issuecomment-2145749773__;Iw!!A... Thanks a lot @larry-cable, appreciated! The new test passes locally for me. I pushed the new test to the PR, feel free to take a look. ------------- PR Comment: https://git.openjdk.org/jdk/pull/19055#issuecomment-2148970901
