On Wed, 5 Jun 2024 01:17:37 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> I think `timeout`s are not needed for the refactored tests. >> Per JDK-6528548 the shell action has timed out using a network mounted JDK >> (MakeJAR2.sh run `javac` 3 times and `jar` 1 time). >> But I don't see big problem here - up to the author to keep or remove them. > > Hello Alex, I agree that the timeout may not be needed. I haven't run the > higher tiers in our CI where `-Xcomp` and other options might slow tests down > in general. So, given Serguei's input, I'll let the timeout stay for now and > once we see how this behaves in higher tiers, then we can remove the timeout > in a subsequent PR if necessary. Agreed. Keeping the timeout for now is more safe at this stage of the release cycle. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19495#discussion_r1626809583
