On Tue, 4 Jun 2024 18:49:03 GMT, Alex Menkov <amen...@openjdk.org> wrote:
>> I have now updated the PR to use the same timeout that was used for the >> `shell` test before the changes in this PR. > > I think `timeout`s are not needed for the refactored tests. > Per JDK-6528548 the shell action has timed out using a network mounted JDK > (MakeJAR2.sh run `javac` 3 times and `jar` 1 time). > But I don't see big problem here - up to the author to keep or remove them. Hello Alex, I agree that the timeout may not be needed. I haven't run the higher tiers in our CI where `-Xcomp` and other options might slow tests down in general. So, given Serguei's input, I'll let the timeout stay for now and once we see how this behaves in higher tiers, then we can remove the timeout in a subsequent PR if necessary. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19495#discussion_r1626802777
