On Thu, 4 Apr 2024 07:31:24 GMT, Stefan Karlsson <stef...@openjdk.org> wrote:
>> Vladimir Kozlov has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits since the last revision:
>>
>> - Address comments
>> - Merge branch 'master' into 8329332
>> - Removed not_used state of nmethod
>> - remove trailing whitespace
>> - 8329332: Remove CompiledMethod and CodeBlobLayout classes
>
> src/hotspot/share/gc/x/xUnload.cpp line 78:
>
>> 76: class XIsUnloadingBehaviour : public IsUnloadingBehaviour {
>> 77: public:
>> 78: virtual bool has_dead_oop(nmethod* const nm) const {
>
> `nmethod* const nm` => `nmethod* nm`. (ZGC's style is to use const for local
> variables, but not for variables in the parameter list). The same applies to
> the rest of the changes to this file.
Okay. I did not know that it is only used for locals. I will update code.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18554#discussion_r1551997411
