On Sat, 16 Dec 2023 04:33:48 GMT, Denghui Dong <dd...@openjdk.org> wrote:
>> I was wondering if it is worth having HeapDumpBeforeFullGC and >> HeapDumpAfterFullGC also mention FullGCHeapDumpLimit. Just something simple >> like "Also see FullGCHeapDumpLimit." Not necessary, but if you think it >> would be useful then please add. > >> nit: should be no space before the last paren. > > fixed. > I was wondering if it is worth having HeapDumpBeforeFullGC and > HeapDumpAfterFullGC also mention FullGCHeapDumpLimit. Just something simple > like "Also see FullGCHeapDumpLimit." Not necessary, but if you think it would > be useful then please add. Make sense. Added. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16976#discussion_r1428685126
