On Sat, 16 Dec 2023 01:09:16 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> Denghui Dong has updated the pull request incrementally with one additional >> commit since the last revision: >> >> change the location of test > > src/hotspot/share/runtime/globals.hpp line 557: > >> 555: "Limit the number of heap dumps triggered by " >> \ >> 556: "HeapDumpBeforeFullGC or HeapDumpAfterFullGC " >> \ >> 557: "(0 means no limit)" ) >> \ > > nit: should be no space before the last paren. I was wondering if it is worth having HeapDumpBeforeFullGC and HeapDumpAfterFullGC also mention FullGCHeapDumpLimit. Just something simple like "Also see FullGCHeapDumpLimit." Not necessary, but if you think it would be useful then please add. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16976#discussion_r1428626556
