On Tue, 5 Dec 2023 16:31:24 GMT, Denghui Dong <dd...@openjdk.org> wrote:
> Hi, > > Could I have a review of this patch? > > In the current implementation, HeapDumpBeforeFullGC/AfterFullGC will generate > dumps for every FGC, increasing the risk of disk full. > > This patch introduces a new option 'FullGCHeapDumpLimit' to limit the number > of dumps triggered by HeapDumpBeforeFullGC/AfterFullGC to enhance > production-friendliness. > > Best, > Denghui Functional changes seem fine, but I think the test is in the wrong place as it is not a dcmd test. Perhaps just place it in test/hotspot/jtreg/serviceability/HeapDump? ------------- Changes requested by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16976#pullrequestreview-1766597251
