On Tue, 28 Nov 2023 05:25:17 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> test/hotspot/jtreg/runtime/Monitor/libMonitorWithDeadObjectTest.c line 131:
>>
>>> 129: if ((*jvm)->DetachCurrentThread(jvm) != JNI_OK)
>>> die("DetachCurrentThread");
>>> 130:
>>> 131: return NULL;
>>
>> Why is this function return type "void*" when it only returns NULL?
>
> @dcubed-ojdk These are the thread routines passed to `pthread_create` and
> must be typed as `void *(*start_routine)(void*)`.
Though I just noticed the parameter is missing. As @stefank has pointed out
this was copied from another test so all of that other test's issues are/were
also present here unfortunately.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16783#discussion_r1407200225
