On Mon, 27 Nov 2023 22:53:16 GMT, Daniel D. Daugherty <dcu...@openjdk.org>
wrote:
>> Stefan Karlsson has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix indentation
>
> test/hotspot/jtreg/runtime/Monitor/libMonitorWithDeadObjectTest.c line 131:
>
>> 129: if ((*jvm)->DetachCurrentThread(jvm) != JNI_OK)
>> die("DetachCurrentThread");
>> 130:
>> 131: return NULL;
>
> Why is this function return type "void*" when it only returns NULL?
@dcubed-ojdk These are the thread routines passed to `pthread_create` and must
be typed as `void *(*start_routine)(void*)`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16783#discussion_r1407195886
