On Fri, 10 Nov 2023 05:44:55 GMT, David Holmes <dhol...@openjdk.org> wrote:

> I just want it confirmed that the proposed test changes will exhibit a leak 
> on all platforms on an unpatched VM. If that can't be ascertained then it may 
> be better to only change for AIX.

On my SUSE Linux x86_64 test box, with the leak (from 8308762: Metaspace leak 
with Instrumentation.retransform) back in the source we have this behavior

-XX:MetaspaceSize=22m -XX:MaxMetaspaceSize=22m   FAILS
-XX:MetaspaceSize=23m -XX:MaxMetaspaceSize=23m   PASSES

So I think we better go for separate settings for AIX and the rest of platforms 
to be on the safe side, because 23m is not really a good choice for Linux 
x86_64, it should still fail with the leak back in.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16553#issuecomment-1805483102

Reply via email to