On Sat, 30 Sep 2023 05:15:59 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> removed othervm mode
>
> test/lib-test/jdk/test/lib/hprof/HprofTest.java line 168:
>
>> 166: }
>> 167:
>> 168: private static void log(Object s) {
>
> Nit: Why is the arg of `Object` type? Also, all calls to `log()` always pass
> `String` type.
Sometimes it it's useful to have ability to log arbitrary objects (or primitive
values which are auto-boxed) without explicit conversion to String
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15953#discussion_r1344629151
