On Fri, 29 Sep 2023 19:21:14 GMT, Alex Menkov <amen...@openjdk.org> wrote:

>> The change fixes 2 issues in hprof test library.
>> The issue were discovered during test development (logging values of dumped 
>> heap objects).
>> - JavaValueArray.elementSize cannot determine size of the array elements and 
>> throws RuntimeException: invalid array element type
>> - JavaObject.toString() method for dumped String objects tries to construct 
>> string value of the object from "value" field assuming "value" field is 
>> array of char. Actually it's byte array, so toString return array values 
>> like "{65, 66, 67}" (with fixed JavaValueArray.elementSize)
>
> Alex Menkov has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   removed othervm mode

Marked as reviewed by lmesnik (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/15953#pullrequestreview-1651578426

Reply via email to