On Tue, 26 Sep 2023 02:04:14 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Afshin Zafari has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> other size_t flags than the ArrayAllocatorMallocLimit are used in tests.
>
> test/hotspot/jtreg/serviceability/attach/AttachSetGetFlag.java line 62:
>
>> 60: // Test a non-manageable size_t flag.
>> 61: // Since it is not manageable, we can't test the setFlag
>> functionality.
>> 62: testGetFlag("StringDeduplicationCleanupDeadMinimum", "128");
>
> A non-experimental flag, like MetaspaceSize, might be better long term in
> case the experimental flag get removed again.
When `MetaspaceSize` is set to 0, following assertion raised at metaspace.cpp:
316
```C++
size_t MetaspaceGC::capacity_until_GC() {
size_t value = Atomic::load_acquire(&_capacity_until_GC);
assert(value >= MetaspaceSize, "Not initialized properly?"); // <-----
return value;
}
`LargePageSizeInBytes` is used instead.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15859#discussion_r1336812986
