On Thu, 21 Sep 2023 12:02:24 GMT, Afshin Zafari <azaf...@openjdk.org> wrote:
> 1. `ArrayAllocatorMallocLimit` is removed. The test cases that tested it also
> are removed.
> 2. `AllocArrayAllocator` instances are replaced with `MallocArrayAllocator`.
> 3. The signature of `CHeapBitMap::free(ptr, size)` is kept as it is, since it
> is called in this way from `GrowableBitMap<T>::resize`, where `T` can be also
> `ArenaBitMap` and `ResourceBitMap`. However, it uses
> `MallocArrayAllocator::free(ptr)` and ignores the `size`:
> ```C++
> void CHeapBitMap::free(bm_word_t* map, idx_t size_in_words) const {
> MallocArrayAllocator<bm_word_t>::free(map);
> }
>
> ### Test
> tiers1-4 passed on all platforms.
Functional removal of code looks good, but some of the test changes need to be
changed.
Thanks.
test/hotspot/jtreg/serviceability/attach/AttachSetGetFlag.java line 64:
> 62: testGetFlag("ArrayAllocatorMallocLimit", "128");
> 63: // testSetFlag("ArrayAllocatorMallocLimit", "64", "128");
> 64:
You need to replace this with another non-manageable size_t flag so that code
coverage is maintained.
test/lib-test/jdk/test/whitebox/vm_flags/SizeTTest.java line 1:
> 1: /*
This test also should not be removed but changed to use a different size_t flag
so that the WB functionality continues to be tested for a flag of this type.
-------------
Changes requested by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15859#pullrequestreview-1639059839
PR Review Comment: https://git.openjdk.org/jdk/pull/15859#discussion_r1333820086
PR Review Comment: https://git.openjdk.org/jdk/pull/15859#discussion_r1333820917
