On Fri, 1 Sep 2023 20:38:28 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
> The fix changes test serviceability/jdwp/AllModulesCommandTest.java to accept
> VM flags.
> 1) The 'ProcessTools.createTestJvm(JDWP_OPT, DEBUGGEE);' is used to start
> debugee
> 2) The stderr is just logging and tests doesn't check if it is empty. stderr
> might contain some VM output which doesn't mean failure
> 3) Some refactoring is done. Method ' public void onStringRead(StreamHandler
> handler, String line) {' doesn't need to check which handler is used and
> corresponding code and methods are deleted. The field 'inputHandler' and
> 'errorHandler' were moved into method.
>
> Tested with tier1-5 to ensure that test correctly work with CI options.
>
> The serviceability/jdwp/AllModulesCommandTest.java is the only one test in
> serviceability/jdwp directory so no other tests should be affected.
>
> I closed my previous PR https://github.com/openjdk/jdk/pull/15499 because
> GitHub incorrectly show changes after merge with backout if the first fix.
This pull request has now been integrated.
Changeset: 5cbff246
Author: Leonid Mesnik <lmes...@openjdk.org>
URL:
https://git.openjdk.org/jdk/commit/5cbff2460812fee707f9d96ab00a628d1ce3fbef
Stats: 63 lines in 3 files changed: 3 ins; 50 del; 10 mod
8315406: [REDO] serviceability/jdwp/AllModulesCommandTest.java ignores VM flags
Reviewed-by: cjplummer, dcubed
-------------
PR: https://git.openjdk.org/jdk/pull/15544
