On Tue, 29 Aug 2023 23:37:06 GMT, Jiangli Zhou <jian...@openjdk.org> wrote:
> Please review this simple change from @cjmoon1 for resolving static linking > issue caused by multiple definition of 'normalize'. @cjmoon1's branch can be > found at: > https://github.com/openjdk/jdk/compare/master...cjmoon1:jdk:fix_normalize. > > The change incorporated suggestions from both @sspitsyn and myself: > > - > https://bugs.openjdk.org/browse/JDK-8313277?focusedCommentId=14604187&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14604187 > - > https://bugs.openjdk.org/browse/JDK-8313277?focusedCommentId=14604187&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14604187 Is `normalize` the only function that causes a conflict and the other changes are just for consistency? If so please just rename normalize to e.g. `normalize_path` ------------- PR Review: https://git.openjdk.org/jdk/pull/15477#pullrequestreview-1603949761
