On Tue, 29 Aug 2023 23:37:06 GMT, Jiangli Zhou <jian...@openjdk.org> wrote:
> Please review this simple change from @cjmoon1 for resolving static linking > issue caused by multiple definition of 'normalize'. @cjmoon1's branch can be > found at: > https://github.com/openjdk/jdk/compare/master...cjmoon1:jdk:fix_normalize. > > The change incorporated suggestions from both @sspitsyn and myself: > > - > https://bugs.openjdk.org/browse/JDK-8313277?focusedCommentId=14604187&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14604187 > - > https://bugs.openjdk.org/browse/JDK-8313277?focusedCommentId=14604187&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14604187 I'm sure I've said it before but there has to be a better way to handle this. We should not have to rename perfectly well-named functions to insert a unique prefix due to static linking conflicts. If this were C++ code rather than C, would that fix things? ------------- PR Review: https://git.openjdk.org/jdk/pull/15477#pullrequestreview-1601777528
