On Wed, 23 Aug 2023 02:51:04 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> Agreed - I assume the change to int was for the release_store etc but that >> is not needed so we can keep the bool type and existing code. > > I was also partly going for consistency with _initialized and _destroyed > w.r.t. int vs bool and 0/1 vs false/true. I can go back to making _destroyed > all bool. Update done. I should also point out that _destroyed is not exported from VMStructs, so could have been made volatile long ago without needing to add any VMStructs support. SA only looks at _initialized, but I suppose you could argue that it also should be checking _destroyed before accessing PerfMemory. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15373#discussion_r1302424008
