On Wed, 23 Aug 2023 01:25:40 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> src/hotspot/share/runtime/perfMemory.hpp line 137:
>>
>>> 135: static size_t capacity() { return _capacity; }
>>> 136: static bool is_initialized();
>>> 137: static bool is_destroyed();
>>
>> So don't we need to make changes here? I think we can keep current
>> implementation ( `is_destroyed()` )
>
> Agreed - I assume the change to int was for the release_store etc but that is
> not needed so we can keep the bool type and existing code.
I was also partly going for consistency with _initialized and _destroyed w.r.t.
int vs bool and 0/1 vs false/true. I can go back to making _destroyed all bool.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15373#discussion_r1302399333
