On Mon, 7 Aug 2023 21:51:39 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> Kimura Yukihiro has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8313854: Some tests in serviceability area fail on localized Windows
>> platform
>
> test/jdk/sun/tools/jhsdb/JShellHeapDumpTest.java line 153:
>
>> 151: long startTime = System.currentTimeMillis();
>> 152: try {
>> 153: ProcessBuilder pb = new
>> ProcessBuilder(JDKToolFinder.getTestJDKTool("jshell"),
>> "-J-Duser.language=en", "-J-Duser.country=US");
>
> I just did a commit that changes this code. You'll need to rework your fix.
> Also, double check to make sure your changes are still necessary. I think
> they are, but it would be good to check first.
Hello Chris,
Thank you for your review.
I understood that 8290497 has a similar fix, as you said.
JShellHeapDumpTest has not fixed yet.
The test always expects "Welcome to JShell" in English as jshell command
message, but jshell prints localized message on the localized Windows platform.
I'm sorry, I didn't understand what rework I should do.
Could you give me advice?
I fixed the copyright year.
Thanks,
Kimura Yukihiro
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15172#discussion_r1286887238
