On Mon, 7 Aug 2023 02:37:15 GMT, Kimura Yukihiro <d...@openjdk.org> wrote:
> I would like to fix this issue
> because the svc jtreg test does not pass on localized Windows platform.
> Testing:
> all serviceability area tests (jdk_svc group).
>
> Could anyone review the fix please?
>
> Thanks,
> Kimura Yukihiro
test/jdk/sun/tools/jhsdb/JShellHeapDumpTest.java line 153:
> 151: long startTime = System.currentTimeMillis();
> 152: try {
> 153: ProcessBuilder pb = new
> ProcessBuilder(JDKToolFinder.getTestJDKTool("jshell"),
> "-J-Duser.language=en", "-J-Duser.country=US");
I just did a commit that changes this code. You'll need to rework your fix.
Also, double check to make sure your changes are still necessary. I think they
are, but it would be good to check first.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15172#discussion_r1286412769
