On Tue, 1 Aug 2023 14:41:53 GMT, Kevin Walls <kev...@openjdk.org> wrote:

> I just saw a run with no -parallel option which got num_active_workers = 2, 
> so it did a parallel dump, so the default is being set as intended, but the 
> availability of worker threads is not always predictable!

Yes, now I've added new log outputs request_dump_thread and num_active_worker 
to get a better look at the details of dump.

> Can we add, like in I think another test: run testng/othervm -Xlog:heapdump 
> HeapDumpTest

Done. In order not to interfere with existing tests, I added checks to the 
IntegrityHeapDumpTest.

> Can we get the signed value in HeapDumpDCmd::execute, print a message and 
> return like we do when compression level is out of range?

Good catch! Done.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13667#issuecomment-1661605782

Reply via email to