On Tue, 1 Aug 2023 17:32:55 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> Yi Yang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> test failure on mac > > test/hotspot/jtreg/serviceability/HeapDump/IntegrityHeapDumpTest.java line 84: > >> 82: .addToolArg(heapDumpFile.getAbsolutePath()); >> 83: >> 84: ProcessBuilder processBuilder = new >> ProcessBuilder(launcher.getCommand()); > > Can you explain this change? This will result in the test not being run with > sudo in cases where sudo is necessary. Before we get here we already checked > if we need sudo (not running as root) and verified that passwordless sudo is > supported. Otherwise the test is skipped and would never get here. So if sudo > is required, the test will fail to attach to the debuggee. Note you might not > see this issue if you have DevSecurityMode enabled. See > [JDK-8313357](https://bugs.openjdk.org/browse/JDK-8313357) I see now that this is a new test, and not an SA test, so probably should never have been using SATestUtils in the first place (I'm curious as to how that ended up happening). You should also remove the import of SATestUtils. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13667#discussion_r1280963213
