On Wed, 21 Jun 2023 20:26:20 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> Daohan Qu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix some code format issues > > I made a couple of minor suggestions. Otherwise it looks good. Thank @plummercj and @sspitsyn for your reviews! > What test coverage does this update have? AFAICS, there are two jtreg tests for class dump — one is [`test/hotspot/jtreg/serviceability/sa/ClhsdbDumpclass.java`](https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/serviceability/sa/ClhsdbDumpclass.java) and another is [`test/hotspot/jtreg/serviceability/sa/TestClassDump.java`](https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/serviceability/sa/TestClassDump.java). The former invoke `javap` on the generated class file to see if it is valid class file while the later directly "invoke" `sun.jvm.hotspot.tools.jcore.ClassDump` to see if it runs without exception. Maybe we could add a validation in `ClhsdbDumpclass.java` to ensure that the generated class file contains some `StackMapTable`s? (As the class under validation `LingeredApp` should has `StackMapTable`s for some methods.) ------------- PR Comment: https://git.openjdk.org/jdk/pull/14556#issuecomment-1601946451
