On Tue, 20 Jun 2023 11:31:40 GMT, Daohan Qu <d...@openjdk.org> wrote:
> This patch adds `StackMapTable` for the class files generated by `clhsdb`'s > `buildreplayjars` command. This bug manifests itself during my diagnosing > [JDK-8309751](https://bugs.openjdk.org/browse/JDK-8309751) and needs to be > fixed first. > > I have run jtreg test `tier1-3` of release build on x86 linux finding only > one failure in `tier2` caused by > [JDK-8309214](https://bugs.openjdk.org/browse/JDK-8309214). > `jtreg:test/hotspot/jtreg/serviceability` and `jtreg:test/jdk/sun/tools/` > also passed. I made a couple of minor suggestions. Otherwise it looks good. src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/ConstMethod.java line 113: > 111: private static MetadataField constants; > 112: // Raw stackmap data for the method (#entries + entries) > 113: private static AddressField stackMapData; I think putting the comment on the same line as the declaration would be better src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/tools/jcore/ClassWriter.java line 173: > 171: // Code attributes > 172: Short stackMapTableIndex = utf8ToIndex.get("StackMapTable"); > 173: _stackMapTableIndex = (stackMapTableIndex != null)? Add a space before the `?` ------------- Marked as reviewed by cjplummer (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/14556#pullrequestreview-1491764984 PR Review Comment: https://git.openjdk.org/jdk/pull/14556#discussion_r1237635649 PR Review Comment: https://git.openjdk.org/jdk/pull/14556#discussion_r1237637155
