On Sun, 4 Jun 2023 11:36:05 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: add to TestJcmdNoAgentLoad default and enabled dynamic loading
>> modes
>
> test/jdk/sun/tools/jcmd/TestJcmdNoAgentLoad.java line 68:
>
>> 66: private static final String[] CMD = new String[] {
>> "JVMTI.agent_load", "Agent.jar" };
>> 67: private static final String PTRN = "Dynamic agent loading is not
>> enabled";
>> 68: private static boolean enableDynLoad = true;
>
> It might be clearer to change this to be a static final field name
> "dynamicLoadingEnabled", just suggesting "enabled" rather than "enable" as
> the usage in this test is to see if the option is enabled.
Good suggestion, thanks. Fixed now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14244#discussion_r1218449527
