On Fri, 2 Jun 2023 19:23:23 GMT, Alex Menkov <amen...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commits since the last revision: >> >> - Merge >> - review: use output.shouldHaveExitValue(0) in the test >> - review: use output.shouldContain() >> - move check for EnableDynamicAgentLoading to invoke_Agent_OnAttach >> - minor renaming in new test TestJcmdNoAgentLoad.java >> - 8304438: jcmd JVMTI.agent_load should obey EnableDynamicAgentLoading > > test/jdk/sun/tools/jcmd/TestJcmdNoAgentLoad.java line 42: > >> 40: * @library /test/lib >> 41: * >> 42: * @run main/othervm -XX:-EnableDynamicAgentLoading TestJcmdNoAgentLoad > > The test verifies only one scenario. I think we need to test 3 scenarios: > - -XX:-EnableDynamicAgentLoading > - +XX:-EnableDynamicAgentLoading > - default (no EnableDynamicAgentLoading arg) I didn't find tests for EnableDynamicAgentLoading for attach API too (to ensure this fix doesn't break it) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14244#discussion_r1214745149
