On Tue, 16 May 2023 22:02:45 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
> This is a follow-on to > [JDK-8308000](https://bugs.openjdk.org/browse/JDK-8308000) which adds JVMTI > PopFrames support for virtual thread. For JDWP and JDI this is mostly a spec > update, although JDI needs minor changes to properly throw the correct > exception. Note this PR needs JDK-8264699 in order to function properly, so > there may be some GHA failures until JDK-8308000 is pushed. > > There are a large number of tests that can now be removed from the problem > list. Also, one test needs to be modified to no longer expect > OpaqueFrameException for virtual threads. It was just revereted back to it's > previous form before the OpaqueFrameException support was added for virtual > threads. > > As you can see from the problemlist update, there are quite a few tests for > popFrames() support. However, there were no existing tests for throwing > NativeMethodException, nor ones that would expose the new > OpaqueFrameException when the virtual thread is suspended but not mounted. > I've added a test that cover these. > > For the new test I added, I needed the fix for: > > [JDK-8308481](https://bugs.openjdk.org/browse/JDK-8308481): JDI TestScaffold > does not support passing app arguments to the debuggee > > So I've included it with this PR. This pull request has now been integrated. Changeset: 89f2d458 Author: Chris Plummer <cjplum...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/89f2d458a293830e271d353c6736907f7e224609 Stats: 553 lines in 9 files changed: 479 ins; 52 del; 22 mod 8308237: add JDWP and JDI virtual thread support for ThreadReference.PopFrames 8308481: JDI TestScaffold does not support passing app arguments to the debuggee 8305632: Test com/sun/jdi/PopAndInvokeTest.java fails with OpaqueFrameException Reviewed-by: alanb, sspitsyn, lmesnik ------------- PR: https://git.openjdk.org/jdk/pull/14022
