On Tue, 23 May 2023 07:49:15 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> This is a follow-on to >> [JDK-8308000](https://bugs.openjdk.org/browse/JDK-8308000) which adds JVMTI >> PopFrames support for virtual thread. For JDWP and JDI this is mostly a spec >> update, although JDI needs minor changes to properly throw the correct >> exception. Note this PR needs JDK-8264699 in order to function properly, so >> there may be some GHA failures until JDK-8308000 is pushed. >> >> There are a large number of tests that can now be removed from the problem >> list. Also, one test needs to be modified to no longer expect >> OpaqueFrameException for virtual threads. It was just revereted back to it's >> previous form before the OpaqueFrameException support was added for virtual >> threads. >> >> As you can see from the problemlist update, there are quite a few tests for >> popFrames() support. However, there were no existing tests for throwing >> NativeMethodException, nor ones that would expose the new >> OpaqueFrameException when the virtual thread is suspended but not mounted. >> I've added a test that cover these. >> >> For the new test I added, I needed the fix for: >> >> [JDK-8308481](https://bugs.openjdk.org/browse/JDK-8308481): JDI TestScaffold >> does not support passing app arguments to the debuggee >> >> So I've included it with this PR. > > Chris Plummer has updated the pull request incrementally with one additional > commit since the last revision: > > set breakpoint in loopOrSleep() rather than popMethod() since it is a bit > closer to the point where the thread blocks. Thanks for the reviews Alan, Serguei, and Leonid! ------------- PR Comment: https://git.openjdk.org/jdk/pull/14022#issuecomment-1561589119
