On Wed, 17 May 2023 02:22:01 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Serguei test comments
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/ThreadStateTest/ThreadStateTest.java
> line 44:
>
>> 42: static final int VTHREAD_COUNT = 64;
>> 43:
>> 44: private static native void SetSingleSteppingMode(boolean enable);
>
> Could you please rename them to 's'etSingleSteppingMode and
> 's'etMonitorContendedMode.
Done.
> test/hotspot/jtreg/serviceability/jvmti/vthread/ThreadStateTest/ThreadStateTest.java
> line 58:
>
>> 56:
>> 57: while (tryCount-- > 0) {
>> 58: ExecutorService scheduler = Executors.newFixedThreadPool(8);
>
> Is it possible to configure pool using any of these parameters?
> -Djdk.defaultScheduler.parallelism=
> -Djdk.defaultScheduler.maxPoolSize=
The reason I'm not using the default scheduler is not to control the size of
the pool but to be able to control its shutdown, since the carriers going away
was part of the ThreadsListHandle crash.
> test/hotspot/jtreg/serviceability/jvmti/vthread/ThreadStateTest/ThreadStateTest.java
> line 93:
>
>> 91:
>> 92: public static void main(String[] args) throws Exception {
>> 93: try {
>
> You could just remove try/catch.
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13949#discussion_r1196701369
PR Review Comment: https://git.openjdk.org/jdk/pull/13949#discussion_r1196701691
PR Review Comment: https://git.openjdk.org/jdk/pull/13949#discussion_r1196701530
