On Mon, 15 May 2023 08:34:53 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Paul Hohensee has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8304704: In getTotalThreadAllocatedBytes javadoc, 'launched' -> 'started' > > src/hotspot/share/services/#allocationSite.hpp# line 1: > >> (failed to retrieve contents of file, check the PR for context) > Shouldn't be here. Removed. > src/hotspot/share/services/.#allocationSite.hpp line 1: > >> (failed to retrieve contents of file, check the PR for context) > Shouldn't be here. Removed. > src/hotspot/share/services/threadService.hpp line 65: > >> 63: >> 64: // As could this... >> 65: // Number of heap bytes allocated by termianted threads. > > typo: termianted Fixed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13814#discussion_r1194447382 PR Review Comment: https://git.openjdk.org/jdk/pull/13814#discussion_r1194447452 PR Review Comment: https://git.openjdk.org/jdk/pull/13814#discussion_r1194447500
