On Fri, 5 May 2023 06:43:20 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Paul Hohensee has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8304074: [JMX] Add an approximation of total bytes allocated on the Java >> heap by the JVM > > src/hotspot/share/services/management.cpp line 2106: > >> 2104: // the loop gets to it and thus not be counted. If, on the other >> hand and done >> 2105: // here, exited_allocated_bytes is added after the loop, the final >> result might be >> 2106: // "too large" because a thread might be counted twice, once in >> the loop and agsin > > typo agsin Fixed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13814#discussion_r1186498560
