On Fri, 5 May 2023 16:16:37 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:

>> Paul Hohensee has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   8304074: [JMX] Add an approximation of total bytes allocated on the Java 
>> heap by the JVM
>
> test/jdk/com/sun/management/ThreadMXBean/ThreadAllocatedMemory.java line 286:
> 
>> 284:     }
>> 285: 
>> 286:     private static long checkResult(Thread curThread,
> 
> There is another `checkResult` below? Should they be replaced by a single 
> method?

No, there's only one checkResult method. I changed the result type from void to 
long.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13814#discussion_r1186491906

Reply via email to