On Mon, 24 Apr 2023 22:41:53 GMT, Mark Powers <mpow...@openjdk.org> wrote:
> Update copyrights to 2023.
Done, thanks.
> src/java.security.jgss/share/native/libj2gss/GSSLibStub.c line 201:
>
>> 199: cb = malloc(sizeof(struct gss_channel_bindings_struct));
>> 200: if (cb == NULL) {
>> 201: gssThrowOutOfMemoryError(env,NULL);
>
> While you're fixing this, add a space between arguments, e.g. `(env,NULL)
> `becomes `(env, NULL)`.
Done, thanks.
> src/java.security.jgss/share/native/libj2gss/NativeUtil.c line 456:
>
>> 454:
>> 455: /* Throws a Java Exception by name */
>> 456: static void throwByName(JNIEnv *env, const char *name, const char *msg)
>> {
>
> Why can't you move the few lines of `throwByName()` into
> `gssThrowOutOfMemoryError()` and totally remove `throwByName()`?
Updated as suggested, thanks.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/13497#issuecomment-1521007212
PR Review Comment: https://git.openjdk.org/jdk/pull/13497#discussion_r1175910048
PR Review Comment: https://git.openjdk.org/jdk/pull/13497#discussion_r1175910110
