On Wed, 29 Mar 2023 01:52:18 GMT, Patricio Chilano Mateo
<[email protected]> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed trailing spaces in two files
>
> src/hotspot/share/prims/jvmtiEnvBase.cpp line 1550:
>
>> 1548:
>> 1549: if (jt->is_in_VTMS_transition()) {
>> 1550: count++;
>
> For those threads that are in a transition when we enable the events,
> shouldn't we also set the jvmti_is_in_VTMS_transition field for the
> corresponding vthread as we do in
> JvmtiVTMSTransitionDisabler::start_VTMS_transition()? It seems a
> JvmtiVTMSTransitionDisabler that targets that particular vthread could
> otherwise proceed after the safepoint while that vthread is still in the
> transition. The "all" JvmtiVTMSTransitionDisabler won't proceed because that
> one does check the _VTMS_transition_count counter. I see that in general we
> won't have access to the vthread oop though.
Nice catch, thanks! Fixed now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13133#discussion_r1152627288
