On Wed, 29 Mar 2023 02:29:16 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixed trailing spaces in two files > > test/hotspot/jtreg/serviceability/jvmti/vthread/ToggleNotifyJvmtiTest/libToggleNotifyJvmtiTest.cpp > line 46: > >> 44: RawMonitorLocker agent_locker(jvmti, jni, agent_lock); >> 45: >> 46: vthread_started_cnt++; > > Wouldn't it be better to use std::atomic<int> instead RawMonitorLocker here > to reduce sync time? This RawMonitorLocker is not on a critical path. It can be useful to sync print statements when tracing is needed. I feel that in order to get a full advantage of it we need to do this for many tests in our test base. I can convert it to std::atomic if you think it is important. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13133#discussion_r1151409885
