On Fri, 24 Mar 2023 06:31:14 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
>> The TestScaffold incorrectly parse options, it should insert wrapper class >> between VM options and applications classame. > > Leonid Mesnik has updated the pull request incrementally with one additional > commit since the last revision: > > added comments and trim arguments Changes look good. I was hoping it would fix more of the failing tests than it did. I get we'll need to take a closer look at them. Would be good to eventually diagnose the root cause of the failures and get bugs filed for each category of failure. test/jdk/com/sun/jdi/TestScaffold.java line 520: > 518: argInfo.targetAppCommandLine = TestScaffold.class.getName() > + ' ' > 519: + mainWrapper + ' ' + argInfo.targetAppCommandLine; > 520: argInfo.targetVMArgs += "--enable-preview "; It looks like previously we ignored `main.wrapper` if not set to `Virtual`, but with your chagnes we accept any setting. That's ok, but `--enable-preview` is really on needed when set to `Virtual`. ------------- Marked as reviewed by cjplummer (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/13170#pullrequestreview-1357465403 PR Review Comment: https://git.openjdk.org/jdk/pull/13170#discussion_r1148078319
