On Fri, 24 Mar 2023 06:31:14 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
>> The TestScaffold incorrectly parse options, it should insert wrapper class >> between VM options and applications classame. > > Leonid Mesnik has updated the pull request incrementally with one additional > commit since the last revision: > > added comments and trim arguments before the fix, the parse args incorrectly compos argInfo, putting all args into targetAppCommandLine, including VM args. So the result for -Xss4M Frames2Targ' was argInfo.targetAppCommandLine : -Xss4M Frames2Targ argInfo.targetVMArgs : without wrapper. Which is not very correct but didn't cause failures. But becomes a problem when the wrapper tries to insert a new class. The old command; argInfo.targetAppCommandLine : TestScaffold Virtual -Xss4M Frames2Targ argInfo.targetVMArgs : --enable-preview The new commands: argInfo.targetAppCommandLine : TestScaffold Virtual Frames2Targ argInfo.targetVMArgs : -Xss4M --enable-preview ------------- PR Comment: https://git.openjdk.org/jdk/pull/13170#issuecomment-1484533916
