On Thu, 23 Mar 2023 08:20:18 GMT, Johannes Bechberger <jbechber...@openjdk.org> wrote:
>> Fixes the issue by transitioning the thread into the WXWrite mode while >> walking the stack in AsyncGetCallTrace. >> >> Tested on my M1 mac. > > Johannes Bechberger has updated the pull request incrementally with one > additional commit since the last revision: > > Use raw_thread instead of Thread::current() So AGCT already breaks in this scenario because WX is not enabled when needed. The code to enable WX is not async-signal_safe, so the "fix" is only a partial fix - it will sometimes fail too. So we go from broken to slightly less broken. This is why AGCT is not supported. Anyway retracting my review while discussion continues. ------------- Changes requested by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/13144#pullrequestreview-1354523473
