On Sat, 11 Feb 2023 07:37:34 GMT, Alan Bateman <al...@openjdk.org> wrote:
> On tests, there are a few other tests that can be changed to drop `@requires > vm.continuations`, e.g. the jshell tests that run with --enable-preview > should no longer need the `@requires`. There are also a few JDI and at least > one AppCDS test. A search will find them. > I removed the vm.continuations requirement on those tests (only SuspendAfterDeath.java and RedefineRunningMethods_Shared.java were actually creating a JVMTI environment though). >The tests re-running with -XX:-VMContinuations is fine but it does mean they >will run twice on the ports without an implementation. The test >runtime/jni/IsVirtualThread/IsVirtualThread.java is an example where it only >runs once on these ports, at the cost of additional `@test` tag. > I see, I removed the extra run and created another @test tag for that with `@requires vm.continuations`, like it is done in IsVirtualThread.java. ------------- PR: https://git.openjdk.org/jdk/pull/12512
