On Wed, 25 Jan 2023 11:47:18 GMT, Johan Sjölen <jsjo...@openjdk.org> wrote:
> Do the conversion in the share/services/ sub-directory and all of its files.
Changes requested by cjplummer (Reviewer).
src/hotspot/share/services/heapDumper.cpp line 1850:
> 1848:
> 1849: void prepare_parallel_dump(uint num_total) {
> 1850: assert (_dumper_controller == nullptr, "dumper controller must be
> nullptr");
The string should say "null", not "nullptr".
src/hotspot/share/services/mallocTracker.hpp line 332:
> 330:
> 331: static inline MallocHeader* malloc_header(void *memblock) {
> 332: assert(memblock != nullptr, "nullptr pointer");
String should say "null", not "nullptr"
src/hotspot/share/services/mallocTracker.hpp line 336:
> 334: }
> 335: static inline const MallocHeader* malloc_header(const void *memblock) {
> 336: assert(memblock != nullptr, "nullptr pointer");
String should say "null", not "nullptr"
src/hotspot/share/services/management.cpp line 1646:
> 1644: typeArrayHandle times) {
> 1645: assert(names() != nullptr, "names was nullptr");
> 1646: assert(times() != nullptr, "times was nullptr");
String should say "null", not "nullptr"
src/hotspot/share/services/management.cpp line 1660:
> 1658: void ThreadTimesClosure::do_thread(Thread* thread) {
> 1659: assert(Threads_lock->owned_by_self(), "Must hold Threads_lock");
> 1660: assert(thread != nullptr, "thread was nullptr");
String should say "null", not "nullptr"
src/hotspot/share/services/threadService.cpp line 224:
> 222: // FIXME: JVMTI should call this function
> 223: Handle ThreadService::get_current_contended_monitor(JavaThread* thread) {
> 224: assert(thread != nullptr, "should be non-nullptr");
String should say "null", not "nullptr"
-------------
PR: https://git.openjdk.org/jdk/pull/12189
