Re: RFR: JDK-8301077: Replace NULL with nullptr in share/services/

[Johan Sjölen]

On Wed, 25 Jan 2023 11:47:18 GMT, Johan Sjölen <jsjo...@openjdk.org> wrote:

> Do the conversion in the share/services/ sub-directory and all of its files.

Found some things to manually fix.

src/hotspot/share/services/attachListener.cpp line 368:

> 366:   { "printflag",        print_flag },
> 367:   { "jcmd",             jcmd },
> 368:   { nullptr,               nullptr }

Align

src/hotspot/share/services/classLoadingService.cpp line 51:

> 49:     int len = 0;                                    \
> 50:     Symbol* name = (clss)->name();                  \
> 51:     if (name != nullptr) {                             \

Align

src/hotspot/share/services/diagnosticFramework.cpp line 40:

> 38:   : _cmd(line), _cmd_len(0), _args(nullptr), _args_len(0)
> 39: {
> 40:   assert(line != nullptr, "Command line string should not be nullptr");

String

src/hotspot/share/services/heapDumper.cpp line 793:

> 791:   void allocate_internal_buffer() {
> 792:     assert(_buffer_queue != nullptr, "Internal buffer queue is not ready 
> when allocate internal buffer");
> 793:     assert(_buffer == nullptr && _buffer_base == nullptr, "current 
> buffer must be nullptr before allocate");

String

src/hotspot/share/services/heapDumper.cpp line 1293:

> 1291: // creates HPROF_GC_CLASS_DUMP record for the given array class
> 1292: void DumperSupport::dump_array_class(AbstractDumpWriter* writer, Klass* 
> k) {
> 1293:   InstanceKlass* ik = nullptr; // bottom class for object arrays, null 
> for primitive type arrays

string

src/hotspot/share/services/memReporter.cpp line 384:

> 382: 
> 383: void MemDetailReporter::report_virtual_memory_region(const 
> ReservedMemoryRegion* reserved_rgn) {
> 384:   assert(reserved_rgn != nullptr, "nullptr pointer");

string

src/hotspot/share/services/memReporter.cpp line 820:

> 818:   outputStream* out = output();
> 819: 
> 820:   assert(stack != nullptr, "nullptr stack");

string

src/hotspot/share/services/memTracker.hpp line 98:

> 96:   static inline void* record_malloc(void* mem_base, size_t size, MEMFLAGS 
> flag,
> 97:     const NativeCallStack& stack) {
> 98:     assert(mem_base != nullptr, "caller should handle nullptr");

String

src/hotspot/share/services/memTracker.hpp line 108:

> 106:   static inline void* record_free(void* memblock) {
> 107:     // Never turned on
> 108:     assert(memblock != nullptr, "caller should handle nullptr");

String

-------------

PR: https://git.openjdk.org/jdk/pull/12189