On Wed, 14 Dec 2022 00:51:34 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add a space
>
> src/hotspot/share/oops/instanceKlassMiscStatus.cpp line 64:
>
>> 62: #ifdef ASSERT
>> 63: void InstanceKlassMiscStatus::assert_is_safe(bool set) {
>> 64: // Setting a flag is safe if it's set once or at a safepoint.
>> RedefineClasses can set or
>
> Is this a generally true statement, or only true for specific flags?
For InstanceKlass, it's true. There are flags that are set at runtime outside
a safepoint that require atomic bit set (is_being_redefined for example) that
are in AccessFlags. They would fail this test. The flags in
MiscStatus::_flags pass this test.
-------------
PR: https://git.openjdk.org/jdk/pull/11655
