On Tue, 13 Dec 2022 18:28:22 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
> These access flags were implemented to enable passing access flag values from
> Method* to InstanceKlass*, but only covered one flag. Towards only have
> access flags represent read-only flags in the class file, remove this and
> pass has_localvariable_table up to InstanceKlass in classfile parsing, like
> we do with other flags.
> Tested with tier1-4.
Thumbs up. I definitely like this cleanup/fix.
Thanks for including the testing info.
src/hotspot/share/prims/jvmtiRedefineClasses.cpp line 4376:
> 4374: if (scratch_class->has_localvariable_table() !=
> 4375: the_class->has_localvariable_table()) {
> 4376:
> the_class->set_has_localvariable_table(scratch_class->has_localvariable_table());
nit: need one more space for indent.
-------------
Marked as reviewed by dcubed (Reviewer).
PR: https://git.openjdk.org/jdk/pull/11655
