On Thu, 27 Oct 2022 01:03:59 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
> Change Thread.resume() to error reporting and add some time to complete
> thread.
Thanks for fixing this issue. It shows up in my stress testing
cycles every week.
test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose003a.java
line 139:
> 137: log1("checking on: thread2.isAlive");
> 138: // There is no sync between
> vm.dispose() and test_thread
> 139: // let give thread some time to complete
nit typo: s/let give/let us give/
Also period at the end of the sentence.
test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose003a.java
line 141:
> 139: // let give thread some time to complete
> 140: boolean isAlive = true;
> 141: for (int attempt = 0; attempt < 5; i++)
> {
Perhaps:
for (int attempt = 1; attempt <= 5; i++) {
Otherwise your first `sleep()` call passes zero.
-------------
Changes requested by dcubed (Reviewer).
PR: https://git.openjdk.org/jdk/pull/10877
